search

ivogabe / Brackets-Icons

File icons in Brackets' file tree
251 stars 59 forks source link

Upper case G for Gruntfile #93

Closed Hirse closed 9 years ago

Hirse commented 9 years ago

According to the Grunt docs, the file name should start with an uppercase G and can also be a CoffeeScript file.

ivogabe commented 9 years ago

Thanks for the PR! You're right about the .coffee extension. For the casing, I think it'd be better to make everything case insensitive. Can you implement that in dictionary.ts? A simple toLowerCase call would do the trick.

Hirse commented 9 years ago

Personally, I prefer to have the known file names case sensitive (or configurable per case) as there might be some case that requires a certain case. Additionally, it encourages correct (or conventional) spelling. :wink:

For the general detection of file extension, I agree that it should ignore the case. But that should be in another PR.

ivogabe commented 9 years ago

I've made filenames case insensitive in 193017bdb27dd932fd4b2dace56e940dceba3e2b. Maintaining a list of which files are case sensitive and which not isn't worth the costs in my opinion.