search

ivogabe / gulp-typescript

A TypeScript compiler for gulp with incremental compilation support.
MIT License
831 stars 129 forks source link

WIP add useFileCompiler setting #616

Open mheiber opened 5 years ago

mheiber commented 5 years ago

enables getting type-checking while enforcing --isolatedModules

fix https://github.com/ivogabe/gulp-typescript/issues/613

mheiber commented 5 years ago

could use some advice on this: https://github.com/ivogabe/gulp-typescript/issues/613#issuecomment-496597930

ivogabe commented 5 years ago

Hi Max, thanks for your PR. Sorry, I have not yet had time to look at your work, O hope to do that this evening or tomorrow.

mheiber commented 5 years ago

No rush, and thanks for your time

mheiber commented 4 years ago

closing, will reopen after incorporating changes

ivogabe commented 4 years ago

Hi Max, have you had time to look into this? Or shall I proceed with this work?

mheiber commented 4 years ago

Apologies, I had to put this aside as we switched to a different solution. I can tidy this up next Sunday, but I understand if you would prefer to take over from here: whatever works.

Thanks again for your feedback!

ivogabe commented 4 years ago

No problem, I also had some other things to do. No hurries, would be great if you could make some time next Sunday!

mheiber commented 4 years ago

Hi @ivogabe , I'm sorry, but I think I'll have to orphan this PR.

It started with a single new flag, but triggered a large refactor of the public API that I'm having trouble fitting in my head, given all the overloads and optional arguments.

I'm no longer using gulp-typescript, so don't want to be a bad user that does a drive-by PR that has such cascading affects on tests, docs, and the future maintainability of the project.

Thanks for your work on gulp-typescript, and apologies for bailing!