search

ivogabe / gulp-typescript

A TypeScript compiler for gulp with incremental compilation support.
MIT License
831 stars 129 forks source link

Output declarations with emitDeclarationOnly #631

Closed edsrzf closed 4 years ago

edsrzf commented 4 years ago

Previously, if there was no JavaScript output from a file, the output would be skipped entirely. This meant that when emitDeclarationOnly was enabled, the declarations would not be written to the dts stream.

Fixes #607.

One note on the test case: I found it actually passed even before making the change because gulp-diff only checks the files that exist in the stream. For example, if the stream is empty, the test will pass, even if there are files in the baseline directory. I did verify that, after my change, if the output differs, the test will fail.

ivogabe commented 4 years ago

Thanks Evan! I'll open an issue for the test issue that you described

edsrzf commented 4 years ago

Thanks for merging! Could we please get a release including this fix?

ivogabe commented 4 years ago

I want to fix some other issues as well, the release should be there in a few days

ivogabe commented 4 years ago

Published as 6.0.0-alpha.1.