search

ivoleitao / stash

Key-value store abstraction with plain and cache driven semantics and a pluggable backend architecture.
MIT License
86 stars 16 forks source link

Update equatable dependency and update sdk restraints #3

Closed jeremiahlukus closed 3 years ago

jeremiahlukus commented 3 years ago

Status

READY

Breaking Changes

NO

Description

Update equatable to ^2.0.0

Related PRs

List related PRs against other branches:

branch PR
PR https://github.com/ivoleitao/stash/pull/3

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

± |develop U:1 ?:1 ✗| → dart example.dart 
Task 1: "Run stash_memory example" is completed

Impact to Remaining Code Base

This PR will affect: From equatable: BREAKING: opt into null safety feat!: upgrade Dart SDK constraints to >=2.12.0-0 <3.0.0 BREAKING: stringify prints "null" for null properties instead of ""

jeremiahlukus commented 3 years ago

@ivoleitao Hey, other packages I have are using equatable ^2 which wont let me use stash or any of its modules. I ran the example.dart file and it appeared to work correctly. I updated the sdk restraints you don't use stringify in the project so it returning "null" as opposed to "" shouldn't matter to you.

https://github.com/ivoleitao/stash/blob/ef4ecb8abbffd34422c0dff0fb2698337ddd8d6e/lib/src/api/codec/msgpack/writer.dart#L52

  String toString() => 'Cyclic error in JSON stringify';

is the only place i see stringify so it really shouldn't matter.

ivoleitao commented 3 years ago

Hi ! You can use the null safety version that I published: https://pub.dev/packages/stash/versions/2.0.0-nullsafety.3. This version already uses equatable 2.0.0

https://github.com/ivoleitao/stash/blob/prerelease/pubspec.yaml.

Try to use this version as it should solve your issue

ivoleitao commented 3 years ago

I intend to move the package out of prerelease state as soon as I'm able to migrate the stash_moor package as it is still dependent on build_runner migration (which should happen this week, I hope)