Closed manychois closed 6 years ago
Merging #17 into master will increase coverage by
0.41%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
+ Coverage 97.75% 98.16% +0.41%
==========================================
Files 4 5 +1
Lines 623 709 +86
==========================================
+ Hits 609 696 +87
+ Misses 14 13 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/HTML5DOMElement.php | 98.78% <100%> (+1.34%) |
:arrow_up: |
src/DOMTokenList.php | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 205dfa1...9375395. Read the comment docs.
Updated to increase unit test coverage.
Thank you for the PR. What do you think about adding a classList attribute (like the one in https://developer.mozilla.org/en-US/docs/Web/API/Element/classList) instead of the methods?
That's even better idea, I can work on that. I'm more inclined to define a getter method classList() then using magic method __get(). What do you think?
Wow. Great job. I think element.classList.add("anotherclass");
(instead of classList()
) will be more familiar to the web developers and will better match the currently available innerHTML
and outerHTML
.
I found myself using this library a lot on class manipulation. It would be handy to have some jQuery-like methods hasClass(), addClass(), removeClass().