search

ivosh / node-nist

A simple low-level ANSI/NIST-ITL 1-2011 (update 2015) encoding and decoding utility library. Written in Typescript for Node.
MIT License
12 stars 6 forks source link

Add support for NIST Type 17 (Iris image) #21

Closed 3r1co closed 7 months ago

3r1co commented 2 years ago

This Pull requests addresses issue 20 . It enables the support for NIST type 17 encoding and decoding

codecov[bot] commented 2 years ago

Codecov Report

Base: 96.49% // Head: 96.49% // No change to project coverage :thumbsup:

Coverage data is based on head (2e92456) compared to base (b1366d4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #21 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 10 10 Lines 770 770 Branches 228 228 ======================================= Hits 743 743 Misses 26 26 Partials 1 1 ``` | [Impacted Files](https://codecov.io/gh/ivosh/node-nist/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr) | Coverage Δ | | |---|---|---| | [src/nistUtils.ts](https://codecov.io/gh/ivosh/node-nist/pull/21/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr#diff-c3JjL25pc3RVdGlscy50cw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ivosh commented 2 years ago

Thank you for the PR. Please could you provide some positive and negative test cases in nistDecode.test.ts and nistEncode.test.ts?

ivosh commented 1 year ago

@3r1co Any news regarding the positive and negative test cases for your PR?

ivosh commented 7 months ago

Almost two years have passed and no test cases provided.