search

ivosh / node-nist

A simple low-level ANSI/NIST-ITL 1-2011 (update 2015) encoding and decoding utility library. Written in Typescript for Node.
MIT License
12 stars 6 forks source link

Add support for NIST record Type-9 #24

Closed isputra closed 1 year ago

isputra commented 1 year ago

This PR activates handling for NIST record Type-9

ivosh commented 1 year ago

Dear Ikhsan, thank you for the PR! Please could you provide unit tests for encoding and decoding a NIST file with Type-9 record (nistDecode.test.ts and nistEncode.test.ts)?

isputra commented 1 year ago

Dear Ikhsan, thank you for the PR! Please could you provide unit tests for encoding and decoding a NIST file with Type-9 record (nistDecode.test.ts and nistEncode.test.ts)?

Hello @ivosh, I've added unit testing for decoding and encoding type-9 record. Let me know if I need to add something else. Thank you.

isputra commented 1 year ago

Hello @ivosh, I've addressed your review comments, could you take a look at the PR ?

ivosh commented 1 year ago

Hello Ikshan, thank you for addressing my comments! Great job! There is just one remaining issue to be resolved, please refer to my comment.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (19b6599) 96.49% compared to head (137e185) 96.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #24 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 10 10 Lines 770 770 Branches 228 228 ======================================= Hits 743 743 Misses 26 26 Partials 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/ivosh/node-nist/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr) | Coverage Δ | | |---|---|---| | [src/index.ts](https://app.codecov.io/gh/ivosh/node-nist/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr#diff-c3JjL2luZGV4LnRz) | `100.00% <ø> (ø)` | | | [src/testNistEncoding.ts](https://app.codecov.io/gh/ivosh/node-nist/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr#diff-c3JjL3Rlc3ROaXN0RW5jb2RpbmcudHM=) | `100.00% <ø> (ø)` | | | [src/nistUtils.ts](https://app.codecov.io/gh/ivosh/node-nist/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Ivo+Raisr#diff-c3JjL25pc3RVdGlscy50cw==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ivosh commented 1 year ago

Available in release 0.7.0. Thanks again, @isputra, for your contribution!