ivpn / android-app

Official IVPN Android app
https://www.ivpn.net/apps-android
GNU General Public License v3.0
291 stars 53 forks source link

Add support for Device Management #309

Closed jurajhilje closed 4 months ago

jurajhilje commented 5 months ago

Description

There are few updates needed to support the Device Management feature:

jurajhilje commented 5 months ago

@gorkapernas IVPNv2.10.7site-Beta-staging.apk is available

gorkapernas commented 5 months ago

@jurajhilje One small text suggestion, when reaching the device limit on Android, the header of the dialog displays the following text: "You have exceeded the maximum number of sessions". Since we are using the term "Devices" everywhere and also to keep consistency with e.g. iOS app, we should change the text to: "You've reached the maximum number of connected devices".

Also, do we need to say "Cancel login" in the same dialog? Can't we just simply use "Cancel"? This also applies to the iOS app.

jurajhilje commented 5 months ago

@gorkapernas I'll update the prompt header text in the next build. Regarding "Cancel" and "Cancel login" - the latter was pulled from the requirements. For me both options are OK, let's just make sure to have the same in all clients.

jurajhilje commented 5 months ago

@gorkapernas New APK is available - device limit prompt header text is updated to match iOS app.

jurajhilje commented 4 months ago

@gorkapernas New APK is available:

gorkapernas commented 4 months ago

Verified on IVPNv2.10.7site-Beta-staging.apk, Redmi Note 10 Android 13, Huawei MediaPad Android 8, all the issues reported have been fixed. Tested with legacy and new account IDs. This is good to go.