[Feature request] Option to prevent same provider Multi-Hop chain

[stenya]

Feature request

Details: https://github.com/ivpn/android-app/issues/16

The ISP info must be shown in GUI: the ISP info has to be added to the 'location' description in the servers list. To think: Shall it be configurable from app settings?

[stenya]

Dialog boxes: 1) Title: "Entry and exit servers located in the same country" Message: "Using Multi-Hop servers from different countries is good practice to increase anonymity." Buttons: "Continue", "Cancel"

2) Title: "Entry and exit servers are operated by the same ISP" Message: "Using Multi-Hop servers operated by different ISPs is good practice to increase anonymity." Buttons: "Continue", "Cancel"

3) Title: "Entry and exit servers are identical" Message: "Please select a different entry or exit server." Buttons: "OK"

@gorkapernas: this functionality is necessary to check when using the servers list and the map + "Connect to location when selecting it on map screen". Implementation is platform-independent.

[stenya]

v3.10.5 is ready for testing

[gorkapernas]

Verified on 3.20.5, see my comments below.

1. Warning messages, both for "same country" and "same ISP" are only displayed when changing the exit server, never when changing the entry server.
2. Related to the issue above, only the exit servers list has greyed out servers, not the entry servers list.
3. Warnings are not shown in the CLI, are you planning to implement them?

Questions:

• What if a user tries to select an entry or exit server in the same country AND with the same ISP, do we need to display both warnings? Currently, only the warning about the "same country" is shown.
• Isn't displaying the server ISP inconsistent with what we display in the connection info as ISP i.e. ISP: IVPN?

//Cc @jurajhilje

[stenya]

Isn't displaying the server ISP inconsistent with what we display in the connection info as ISP i.e. ISP: IVPN? @gorkapernas @jurajhilje good question. Let's discuss it on Monday

What if a user tries to select an entry or exit server in the same country AND with the same ISP, do we need to display both warnings? Currently, only the warning about the "same country" is shown. I prefer to keep it as is.

[stenya]

• [fix] Related to the issue above, only the exit servers list has greyed out servers, not the entry servers list. - fixed
• [new] CLI: Added ISP info into command output ivpn servers
• [improvement] CLI: Warnings are not shown in the CLI, are you planning to implement them? - CLI prints warnings but continues connections. I think it should not wait for user action (for CLI)

v3.10.7 is ready for testing

[gorkapernas]

Verified on v3.10.7, all platforms + CLI, all the new changes have been implemented correctly. This is good to go.

[stenya]

Issues found:

Map STR: 1) Settings->Connect to location when selecting it on map => disabled 2) Settings->Warn me when electing ... servers located in the same country => enabled 3) Multi-Hop connected to entry server from country-X, exit server from country-Y 4) Click a location on map from country-X
Observed result: The warning appears ("servers located in the same country") Expected result: No warnings must be here, because we do not change servers.

Tray: favorire servers STR: 1) Add "server-1" from Country-X to favorite servers 2) Switch to Multi-Hop 3) Select entry server "server-2" from country-X
Observed result: The tray menu does NOT show favorite servers (because the entry server and server from 'favorites' are located in the same country). Expected result: The tray menu must show the favorite server (from step 1). The warning only must appear when a user selects the favorite server from the tray menu (favorite servers)

[stenya]

v3.10.8

[gorkapernas]

Reopening this ticket since further work is needed.

//Cc @jurajhilje

[gorkapernas]

Verified in the latest beta 3.10.11, all platforms, all the issues reported have been fixed.

[gorkapernas]

@stenya as discussed, we need to implement the following change:

• MultiHop Only -> when "Random Server" is selected either as entry or exit server, the app should never selects a sever with the same ISP or from the same country, regardless if the Country/ISP alerts are enabled or disabled.

[stenya]

v3.10.12

[gorkapernas]

Verified on v3.10.12, all platforms, the last requested change has been implemented correctly. When "Random Server" is selected either as entry or exit server, the app never selects a sever with the same ISP or from the same country, regardless if the Country/ISP alerts are enabled or disabled.

[stenya]

v3.10.14 released