ivpn / desktop-app

Official IVPN Desktop app
https://www.ivpn.net/apps/
GNU General Public License v3.0
351 stars 48 forks source link

(Linux) Build fails from AUR if servers.json cannot be retrived #242

Closed jordan-ivpn closed 1 year ago

jordan-ivpn commented 1 year ago

Bug report

Describe your environment

Describe the problem

The build process from AUR retrieves the current servers.json file. If a network restriction blocks access to api.ivpn.net, the build fails.

An improvement might be to bundle servers.json with the source just in case it cannot be retrieved over the network.

A different improvement might be to hardcode the api.ivpn.net IP addresses and failover in case servers.json is inaccessible using the hostname.

An alternative improvement might be to host servers.json on GitHub or on some other domain for when api.ivpn.net is not available, though this likely involves some backend or infrastructure support.

Thanks.

stenya commented 1 year ago

AUR updated: https://aur.archlinux.org/cgit/aur.git/commit/?h=ivpn&id=822f3a09f0c4851718ce15f7879c4b48d21b72fe

The servers.json is already bundled into the GitHub repository. The bundled version will be used in case of failure to download the latest version of servers.json.

The change will start work after the next official ivpn version is released.

stenya commented 1 year ago

@gorkapernas FYI: I tested it myself.

stenya commented 1 year ago

v3.10.14 released