Update favorite locations/hosts logic

[jurajhilje]

We want to have the same list of favorite locations and hosts for all VPN protocols. So when user switches to different VPN protocol, the app need to show the same favorite list of servers that are available for that protocol.

Location

For location, we can match if the gateway prefix (e.g. gb. or us-ca.) is available for current VPN protocol.

Host

For specific host, we can match if the host with the dns_name is available for current VPN protocol.

[stenya]

@gorkapernas Related functionality (requires regression tests):

• favorite servers and hosts management (add/remove)
• upgrade from the previous app version: the user's favorite locations/hosts must not disappear. They must be correctly migrated to a new logic.

[stenya]

v3.10.8

[gorkapernas]

Verified on v3.10.8, @stenya actually there is an issue on upgrade, only the locations are migrated, not the hosts. This issue is observed with servers with multiple hosts like Amsterdam, if you add all hosts to the favorite list in the old IVPN version and upgrade to the latest 3.10.8, only the location Amsterdam will appear in the favorite list, no its hosts.

[stenya]

@gorkapernas Can you, please, provide more details? I can not reproduce the issue you described. Please, see the video: https://a.cl.ly/WnuZWRBN

[gorkapernas]

Issue https://github.com/ivpn/desktop-app/issues/244#issuecomment-1403983017 Only related to macOS intel. ^^

[stenya]

The related issue is on Linux. STR: 1) Install v3.10.0 ivpn & ivpn-ui 2) Select favorite hosts (e.g Amsterdam) 3) Disable internet connectivity! 4) Install v3.10.8 ivpn & ivpn-ui

Observed result: All hosts are in favorites (even hosts which were not selected)

[gorkapernas]

@stenya there is another issue, certain hosts appear twice in the favorite list, this issue only happens with OpenVPN. It occurs only when adding servers with WireGuard on those locations with multiple hosts, but only one on OpenVPN e.g. Milan, IT -> it1 and it01 with WG, it1 with OpenVPN.

Steps:

1. Add the location Milan, IT, and the hosts it1 and it01 to favorites with WG.
2. Switch to OpenVPN.
3. Open the favorite list.
4. Observe the issue.

The issue can also be reproduced with these servers: se, ca-qc and sg.

See screenshot for further details:

Also note that a similar issue happens on iOS, ref: https://github.com/ivpn/ios-app/issues/264#issuecomment-1405143415

Expected:

Only one location should be displayed.

---

UPDATE: The issue is also present in the favorite list from the system tray menu.

[stenya]

v3.10.9

[gorkapernas]

Verified on v3.10.9, all platforms, all the issues reported have been fixed, the favorite servers feature looks and works as expected now according to the new logic described in the ticket.

[stenya]

v3.10.14 released