search

ivpn / desktop-app

Official IVPN Desktop app
https://www.ivpn.net/apps/
GNU General Public License v3.0
322 stars 49 forks source link

Adding IVPN cli to PATH delete all environment variables!! #262

Closed m-primo closed 1 year ago

m-primo commented 1 year ago

Bug report

Describe your environment

Describe the problem

When installing/updating IVPN desktop app and choosing "Add IVPN cli to PATH" it will remove all your current environment variables (system environment variables not user)

Steps to reproduce:

  1. Install IVPN.
  2. Check "Add IVPN cli to PATH" box.
  3. Check your system environment variables.. it's gone!!!

Observed Results:

Screenshot 2023-03-12 034721

Expected Results:

Nothing to be deleted!!

stenya commented 1 year ago

Similar closed issue: https://github.com/ivpn/desktop-app/issues/239

m-primo commented 1 year ago

Similar closed issue: #239

It's not a solution, the issue still persist, and it's from IVPN itself, not "malicious agent". If it's a "malicious agent" it wouldn't happen literally after the installation of the IVPN app!!

stenya commented 1 year ago

Hi @m-primo The linked ticket is just for reference, mainly for myself and other IVPN colleagues.

In the meantime, could I ask for your help in determining the issue?:

  1. Could you please confirm whether the issue occurs every time you install the IVPN app?
  2. Would you be able to share the value of your PATH variable before installing the IVPN app?
m-primo commented 1 year ago
  1. Could you please confirm whether the issue occurs every time you install the IVPN app?

I tried twice and it occurred, so yes.

  1. Would you be able to share the value of your PATH variable before installing the IVPN app?

I have lots of variables so Untitled

stenya commented 1 year ago

The issue has been confirmed. To reproduce the issue, the PATH system variable must have a length of more than 1024 bytes. I am currently working on a fix. @gorkapernas ^^^ FYI

gorkapernas commented 1 year ago

Verified fixed on beta 3.10.15, as Stenya mentioned, the installer framework does not allow variables with more than 1024 characters, so currently when installing IVPN and trying to add the CLI to the PATH under such conditions, the installer won't update the PATH and the user will be presented with the following message.

variables issue_warning
stenya commented 1 year ago

v3.10.15 is released.

@m-primo Thank you for your help.