ivpn / ios-app

Official IVPN iOS app
https://www.ivpn.net/apps-ios
GNU General Public License v3.0
418 stars 85 forks source link

MultiHop selected even if cancelling dialog #165

Open gorkapernas opened 2 years ago

gorkapernas commented 2 years ago

Description

On version 2.4.2, as well as on beta 2.5.0, when connecting with OpenVPN and selecting MultiHop while connected, the app shows a dialog to reconnect, if the user cancels it, the app will still show the entry and exit server in the main UI, and the circle animation will be in the exit server, however the app is still connected with SingleHop.

Actual result:

MultiHop selected in the UI even if cancelling dialog.

Expected result:

The app should revert to SingleHop when the user cancels the dialog.

Steps to reproduce:;

  1. Install App Store version 2.4.2.
  2. Login with a Pro account.
  3. Select OpenVPN.
  4. Connect to any server.
  5. Tap on 'MultiHop'.
  6. Observe the dialog, tap on 'Cancel'.
  7. Observe the circle animation goes to the exit server and the UI shows both entry and exit server, however the app is still connected to SingleHop.

Environment:

IVPN: 2.4.2, 2.5.0 Devices: iPhone XR iOS 15, iPad 6 iOS 14.6

Attachment:

https://user-images.githubusercontent.com/16647612/129381105-d03b1286-30f9-4f85-a124-3e2e7efaae95.mp4

jurajhilje commented 2 years ago

This is an UX issue and it can be misleading. As discussed, an ideal solution for all settings that require a VPN reconnect is that new settings + UI change is done only if the prompt is confirmed.