Add “Block LAN traffic” action for untrusted networks

[jurajhilje]

Description

In the Network Protection settings, add “Block LAN traffic” action for untrusted networks. Note that when enabled, this option overrides the same option in Settings -> Advanced.

[jurajhilje]

@gorkapernas Available for QA in 2.11.1 (1)

[gorkapernas]

Verified on 2.11.1 (1), see my comments below.

• When enabling "Block LAN traffic" for untrusted networks, it seems like the action blocks LAN traffic regardless of the network trust status, so it doesn't matter if the network is untrusted or not.
• When the app is connected to the VPN, enabling "Block LAN traffic" action does not ask the user to reconnect.

Suggestion:

• It is suggested to add also a tooltip in the "Block LAN traffic" from he Advance settings, this would be consistent with the desktop apps. See message below from the desktop app for reference.

Suggested text: "Network Protection" actions for untrusted networks will override this option.

[jurajhilje]

@gorkapernas New build 2.11.1 (3) is available, with fixes and improvements for your last comment.

[gorkapernas]

Verified on version 2.11.1 (3), the fixes and suggestions from my last comment have been implemented correctly. However, I'm still experiencing a couple of issues when enabling "Block LAN traffic" from the Advance settings.

1. "Block LAN traffic" action for untrusted networks doesn't seem to override the same option from Advance settings. When both "Block LAN traffic" options are enabled, but without setting any trust status, the local area network is still blocked. In this case, since the network was not set as untrusted, LAN access should be allowed.

   Steps:

   • Enable Network Protection
   • Do not change any network trust status
   • Enable "Block LAN traffic" for untrusted networks in the Network Protection settings
   • Enable "Block LAN traffic" in Advance settings
   • Connect to the VPN
   • Observe that LAN access is blocked.

2. Frequently, the app fails to connect with WireGuard when "Block LAN traffic" from Advance settings is enabled (same option in Network Protection is disabled)

   Steps:

   • Enable Network Protection
   • Enable "Block LAN traffic" in Advance settings
   • Connect to the VPN

[jurajhilje]

@gorkapernas New build 2.11.1 (6) is available:

• Updated "Block LAN traffic" tooltip message to match Desktop app

[jurajhilje]

@gorkapernas New build 2.11.1 (7) is available:

• Updated NP tooltip as discussed

[gorkapernas]

Verified on 2.11.1 (7), the tooltip has been updated correctly. There are no more open issues and the feature works as expected, only when "Block LAN traffic" action is enabled and the user connects to an untrusted network, the LAN traffic is blocked.