search

ivpusic / react-native-image-crop-picker

iOS/Android image picker with support for camera, video, configurable compression, multiple images and cropping
MIT License
6.05k stars 1.54k forks source link

Cropper is not showing when multiple is set to true #1243

Open suhailk16 opened 4 years ago

suhailk16 commented 4 years ago

Version

Platform

Expected behaviour

Show Cropper view when multiple is set to true

Actual behaviour

when multiple is set to false after picking image Cropper is showing but not when multiple is true

Steps to reproduce

just set 

{
  multiple: true,
  cropping: true,
}
abhi-nahi commented 4 years ago

Same issue here !

PrashenAlumnus commented 4 years ago

Same issue facing

hossein-zare commented 4 years ago

When the multiple is true the cropper frame doesn't show up.

dhruv-toptal commented 4 years ago

Same Issue

abdelmagied94 commented 4 years ago

I adjusted the package to enable cropping if the user selects only one image while multiple flag is true. I think this would be a better solution till we make a full solution to crop all images. If you find this a good idea, It would be my pleasure to make a PR with it.

suhailk16 commented 4 years ago

Thanks for your support, for now, yes please make a PR. But I am looking forward to full solutions to crop all images.

VincentCATILLON commented 4 years ago

Just to share my solution with the 0.25.3 release (as i'm on 0.60.x RN version) and can't wait for this fix:

ImagePicker.openPicker({
  ...imagePickerOptions,
  compressImageMaxWidth: 1000,
  compressImageMaxHeight: 1000,
  multiple: true,
  mediaType: 'photo',
}).then(async images => {
  const result = [];

  for (const image of images) {
    result.push(
      await ImagePicker.openCropper({
        path: image.path,
        width: 1000,
        height: 1000,
      })
    );
  }

   return result;
});

HPH

myckhel commented 3 years ago

https://github.com/ivpusic/react-native-image-crop-picker/issues/1344#issuecomment-687113083

tastyqbit commented 3 years ago

Any updates on this?

Mihai-github commented 2 weeks ago

Also interested in this feature