search

ivpusic / react-native-image-crop-picker

iOS/Android image picker with support for camera, video, configurable compression, multiple images and cropping
MIT License
6.13k stars 1.56k forks source link

[FEATURE REQ] durationLimit for videos #1346

Open hannojg opened 4 years ago

hannojg commented 4 years ago

Version

Tell us which versions you are using:

Platform

Expected behaviour

For example, the react-native-image-picker library has a durationLimit option when opening the picker or camera. using this we can set a limit for video's duration. I would love to have such an option in this library too. Is this possible?

Attachments

https://github.com/react-native-community/react-native-image-picker/blob/master/docs/Reference.md See reference

hannojg commented 4 years ago

Similar to #1338

hannojg commented 4 years ago

I think this can be achieved "quite easily":

2xSamurai commented 4 years ago

@hannojg Sorry for asking. But I don't understand what you have pointed out. Is the feature for limiting the video duration implemented already? I can see a variable called 'durationLimit'. But have no idea whether its implemented or not. Please help.

Awesome plugin by the way. Thank you for your hard work.

hannojg commented 4 years ago

Hey, where do you see this variable?

I am talking about something like this:

ImageCropPicker.openPicker({
      durationLimit: LIMIT_IN_MS
    })
khurram-wasim commented 4 years ago

Hi, Kindly find this in following PR

https://github.com/ivpusic/react-native-image-crop-picker/pull/1384

P.s duration limit is in seconds in this PR

mrousavy commented 3 years ago

see #1463