ivrit-ai / ivrit.ai

ivrit.ai codebase
MIT License
24 stars 9 forks source link

sevral changes #24

Closed ttv20 closed 1 month ago

ttv20 commented 8 months ago
yairl commented 8 months ago

Sorry for the delay in replying, I did not notice this PR.

How big will the text area be? Can you quickly explain your other changes?

wrt alerts, can you put this in a function instead of modifying the field locally in every location? Would make it easier to use for other alerts later on.

ttv20 commented 8 months ago

השדה טקסט יגדל כדי להתאים לטקסט אבל לא יגרום לדף להיות עם גלילה בפלאפון הדף יתפוס את כל הגובה ולא רק חלק והגבולות בצדדים יקטנו הפופאפ של 'לא הצלחתי' יהיה יותר נמוך בפלאפון ובמרכוז תקין וישר ומחשב מקטע ומקור יהיו באותה שורה כי רוב האנשים לא צריכים לדעת איזה מס' מקטע זה וזה תופס מקום לאורך (את זה אפשר לבטל) במקום אלרט הוא כותב טקסט אדום מהבהב מעל הכפתורים שנעלם ברגע שלוחצים play שוב

yairl commented 8 months ago
  1. I think it makes more sense to keep the header (loggied in as ... and statistics) centered.
  2. Best to maintain order between the fields, even if they're in the same line: source | episode | segment (reversed in hebrew).
yairl commented 7 months ago

Apologies for acting slowly. If you can fix the conflicts, I'm happy to test and merge.

nnrepos commented 7 months ago

will this solve the hidden text problem when rotating the screen in mobile? 908697d4-f2cc-4bc2-822f-40559c6cd5b7

@ttv20

yairl commented 7 months ago

will this solve the hidden text problem when rotating the screen in mobile? 908697d4-f2cc-4bc2-822f-40559c6cd5b7

@ttv20

I hope so, it's one of the issues I hate most.

yairl commented 7 months ago

@nnrepos feel like doing conflict resolution here so this one can proceed? :)

nnrepos commented 7 months ago

@nnrepos feel like doing conflict resolution here so this one can proceed? :)

sure, do i have write access?

nnrepos commented 7 months ago

@yairl i am lost here - i don't have access to @ttv20's branch, therefore i can only create a new PR with their changes, and fix the conflicts in my copied branch, correct? is that your intention?

yairl commented 7 months ago

@yairl i am lost here - i don't have access to @ttv20's branch, therefore i can only create a new PR with their changes, and fix the conflicts in my copied branch, correct? is that your intention?

Yes.

nnrepos commented 7 months ago

i cherry-picked this into a new branch. when i tested it, i found that on some low-resolution devices (e.g. iPhone SE, Surface Duo) the buttons are pushed out of the main body: image

i'm not good enough at CSS to fix this issue, therefore i'm not creating a PR. @ttv20 feel free to fix this and resolve conflicts

yairl commented 1 month ago

Unhandled for a long time - closing.