Closed ttv20 closed 1 month ago
Sorry for the delay in replying, I did not notice this PR.
How big will the text area be? Can you quickly explain your other changes?
wrt alerts, can you put this in a function instead of modifying the field locally in every location? Would make it easier to use for other alerts later on.
השדה טקסט יגדל כדי להתאים לטקסט אבל לא יגרום לדף להיות עם גלילה בפלאפון הדף יתפוס את כל הגובה ולא רק חלק והגבולות בצדדים יקטנו הפופאפ של 'לא הצלחתי' יהיה יותר נמוך בפלאפון ובמרכוז תקין וישר ומחשב מקטע ומקור יהיו באותה שורה כי רוב האנשים לא צריכים לדעת איזה מס' מקטע זה וזה תופס מקום לאורך (את זה אפשר לבטל) במקום אלרט הוא כותב טקסט אדום מהבהב מעל הכפתורים שנעלם ברגע שלוחצים play שוב
Apologies for acting slowly. If you can fix the conflicts, I'm happy to test and merge.
will this solve the hidden text problem when rotating the screen in mobile?
@ttv20
will this solve the hidden text problem when rotating the screen in mobile?
@ttv20
I hope so, it's one of the issues I hate most.
@nnrepos feel like doing conflict resolution here so this one can proceed? :)
@nnrepos feel like doing conflict resolution here so this one can proceed? :)
sure, do i have write access?
@yairl i am lost here - i don't have access to @ttv20's branch, therefore i can only create a new PR with their changes, and fix the conflicts in my copied branch, correct? is that your intention?
@yairl i am lost here - i don't have access to @ttv20's branch, therefore i can only create a new PR with their changes, and fix the conflicts in my copied branch, correct? is that your intention?
Yes.
i cherry-picked this into a new branch. when i tested it, i found that on some low-resolution devices (e.g. iPhone SE, Surface Duo) the buttons are pushed out of the main body:
i'm not good enough at CSS to fix this issue, therefore i'm not creating a PR. @ttv20 feel free to fix this and resolve conflicts
Unhandled for a long time - closing.