ivukotic / ml_platform

ML platform container
GNU General Public License v3.0
3 stars 7 forks source link

Revert reduction in Julia build script #28

Open Moelf opened 2 months ago

Moelf commented 2 months ago

A bunch of packages are deleted in https://github.com/ivukotic/ml_platform/commit/d56ea9089b748a4e9cf1281fb0d8cbccb0df7c67

can we revert that?

ivukotic commented 2 months ago

Do you really need all of them?

From: Jerry Ling @.> Sent: Monday, April 22, 2024 10:47 To: ivukotic/ml_platform @.> Cc: Subscribed @.***> Subject: [ivukotic/ml_platform] Revert reduction in Julia build script (Issue #28)

A bunch of packages are deleted in d56ea90https://urldefense.com/v3/__https:/github.com/ivukotic/ml_platform/commit/d56ea9089b748a4e9cf1281fb0d8cbccb0df7c67__;!!BpyFHLRN4TMTrA!91JXHilYZaRaG0ZVSO0kMKPSj89JZMptxIpedRjnCloONTNF3hapBN8gGrnTiAzlgBSY576Mr5MB13B3cK5ZLtlZBUUP$

can we revert that?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/ivukotic/ml_platform/issues/28__;!!BpyFHLRN4TMTrA!91JXHilYZaRaG0ZVSO0kMKPSj89JZMptxIpedRjnCloONTNF3hapBN8gGrnTiAzlgBSY576Mr5MB13B3cK5ZLkjgCyWs$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AANICGC2HJKIE3HAFKONIG3Y6UWGHAVCNFSM6AAAAABGTBNT56VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TMOBYHA4TIMQ__;!!BpyFHLRN4TMTrA!91JXHilYZaRaG0ZVSO0kMKPSj89JZMptxIpedRjnCloONTNF3hapBN8gGrnTiAzlgBSY576Mr5MB13B3cK5ZLvETzXpJ$. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

Moelf commented 2 months ago

Currently not all of them, but at least we should have uproot and RISE.

In general I want to avoid people switching between Python and Julia image just to find something is missing.

ivukotic commented 2 months ago

let me try putting them back.

ivukotic commented 2 months ago

something strange is going on. image is built correctly. Upload of the image to dockerhub works fine, but to harbor it fails without any output. Maybe we should move to using docker image...

Moelf commented 2 months ago

interesting.... no rush tough, take your time and thank you for looking into this