search

ivy-llc / demos

Demos and Tutorials with Ivy
https://ivy.dev/docs/demos/
19 stars 61 forks source link

Enabling demos tests with nightly binaries #68

Closed vedpatwardhan closed 1 year ago

vedpatwardhan commented 1 year ago
  1. Added a way to dispatch the .github/workflows/run-test-suite.yml workflow with an input about whether binaries should be pulled from the nightly branch.
  2. Mounting the volume of the latest clone of ivy everytime rather than the one present inside the docker image that gets updated once a day
vedpatwardhan commented 1 year ago

Hey @Dsantra92, here's an example workflow with the nightly binaries, you'd need to go to the workflow page, select the branch as demos_tests_nightly (as we're yet to merge the PR) and pass "true" for the "Testing with nightly binaries : " field as shown in the image to trigger the workflow with the nightly binaries. Let me know if there's any changes to be made, thanks 😄

Screenshot 2023-11-09 at 2 12 53 PM
Dsantra92 commented 1 year ago

LGTM. Feel free to merge when it's ready @vedpatwardhan.

vedpatwardhan commented 1 year ago

Awesome, thanks @Dsantra92 😄 Also, I saw a nightly branch on the ivy repo as well just like the binaries repo, do you want the demos tests running using the nightly branch binaries to also use the ivy repo's nightly branch?

Dsantra92 commented 1 year ago

Yep, we would need the ivy nightly branch. Otherwise new binaries and function definitions wouldn't work.

vedpatwardhan commented 1 year ago

Yep, we would need the ivy nightly branch. Otherwise new binaries and function definitions wouldn't work.

done, I'll merge the PR now, but there seems to be an additional test failure in the nightly branch with the torch_to_jax demo as compared to the current code and binaries. I'd suggest looking into that issue before merging the nightly binaries into main. Thanks @Dsantra92 😄