Open akshatvishu opened 1 year ago
Hey @akshatvishu
This issue was up on my radar, but I was still caught up in other things on my plate π Will surely get started on fixing this π€
Thanks for bringing it up π«‘
Hey @akshatvishu
This issue was up on my radar, but I was still caught up in other things on my plate π Will surely get started on fixing this π€
Thanks for bringing it up π«‘
Thanks for looking into this @hirwa-nshuti !
Also, shall I close this issue now?
Hey @akshatvishu This issue was up on my radar, but I was still caught up in other things on my plate π Will surely get started on fixing this π€ Thanks for bringing it up π«‘
Thanks for looking into this @hirwa-nshuti !
Also, shall I close this issue now?
Will close it once everything is implemented π
Problem Description:
I was going through the
issue_list
: Add creation functions to Jax frontend #8431 and found out that some of the function present there to implement are actually classes:Task present in issue list which are
classes
:and
fromfile
andfromiter
that are also present in theissue_list
are not implemented in thejax
itself due them maybe being non-pure and thus, unsafe for use withJIT
and otherJAX
transformations.refs: https://github.com/google/jax/blob/main/jax/_src/numpy/lax_numpy.py
Instead what can be done is to make open issue for:
similar to uint16 #5130 and int16 #7677
Basically everything that uses
_make_scalar_type
can be made into an issue with the same name and can be added to ivy jax frontend atcreation.py
Because currently if we try to implement any of the above classes in jax frontend then it throws error like Discord Link
Another similar issue was faced in-here too: https://github.com/unifyai/ivy/issues/11170