ivy-llc / ivy

The Unified ML Representation
https://ivy.dev
Other
14.03k stars 5.82k forks source link

Fix Frontend Failing Test: paddle - comparison.numpy.less_equal #28688

Open ZJay07 opened 3 months ago

ZJay07 commented 3 months ago

PR Description

https://www.paddlepaddle.org.cn/documentation/docs/en/2.2/api/paddle/less_equal_en.html#less-equal Specify dtypes based on paddlepaddle docs

Related Issue

Close https://github.com/unifyai/ivy/issues/28687

Checklist

Socials

ZJay07 commented 3 months ago

In addition, the function also seems to be explicitly handling complex types.

Hi @Ishticode, thanks for the review, should the function be allowed to handle complex type, is it mainly to accommodate the jax implementation?

Ishticode commented 3 months ago

In addition, the function also seems to be explicitly handling complex types.

Hi @Ishticode, thanks for the review, should the function be allowed to handle complex type, is it mainly to accommodate the jax implementation?

Yes. Does it get the same results as jax?

ZJay07 commented 3 months ago

Hey @Ishticode managed to fix it seems like it was missing some equal signs since it is comparing less_equal. And from what I understand the idea for numpy comparisons for complex numbers is to compare real first, if its <= then return True, else if the real part is equivalent compare the <= of the imag part

Ishticode commented 2 months ago

any updates @ZJay07 on this one? :)

ZJay07 commented 2 months ago

Hey @Ishticode, currently busy with exams but will be back to fixing it later this month!