ivy-llc / ivy

The Unified ML Representation
https://ivy.dev
Other
14.02k stars 5.82k forks source link

update setting_up.rst #28744

Closed Satarupa22-SD closed 1 month ago

Satarupa22-SD commented 2 months ago

PR Description

Updates the path for requirements.txt file present in the requirements directory

Related Issue

Checklist

Socials

Satarupa22-SD commented 2 months ago

@Sam-Armstrong please look into it. Thanks :)

Sam-Armstrong commented 1 month ago

@Satarupa22-SD did we establish in the discord discussion that this doc was actually correct because it was referring to the requirements in the ivy/ivy_tests/array_api_testing/test_array_api folder?

Satarupa22-SD commented 1 month ago

@Sam-Armstrong we were referring to separate sections in the documentation which is why there was confusion, someone pointed that out later 😅. However, please feel free to look into it again. 🙂

Satarupa22-SD commented 1 month ago

@Sam-Armstrong however I do feel the change made is correct because if you would notice the previous commands all of them are referencing the files inside the requirements directory. :)

Sam-Armstrong commented 1 month ago

@Satarupa22-SD I think this is correct for Installing array API testing dependencies, as there is a requirements.txt file under the ivy/ivy_tests/array_api_testing/test_array_api directory, and this section of the docs is specifically referring to the dependencies for array api testing.

Ishticode commented 1 month ago

Based on the comments from @Sam-Armstrong it seems like its best to close this PR. Please feel free to suggest otherwise @Satarupa22-SD