ivy-llc / ivy

The Unified ML Representation

https://ivy.dev

Other

14.02k stars 5.82k forks source link

fix: fixed `test_numpy_mean` for all backends #28755

Closed ZenithFlux closed 1 month ago

ZenithFlux commented 1 month ago

PR Description

fixed the tuple destructuring error in the function.
Numpy's mean is not as exact as of other frameworks. It sometimes rounds up the mean while other frameworks don't which causes some mismatch in results. Therefore an atol of 0.0005 is added to the test.

Related Issue

Closes #28751 Closes #28752 Closes #28753 Closes #28754

Checklist

[ ] Did you add a function?
[ ] Did you add the tests?
[x] Did you run your tests and are your tests passing?
[x] Did pre-commit not fail on any check?
[x] Did you follow the steps we provided?

Socials

Sam-Armstrong commented 1 month ago

Apologies for the delayed review @ZenithFlux, looks good to me. Thanks for the contribution!