search

ivy-llc / ivy

Convert Machine Learning Code Between Frameworks
https://ivy.dev
Other
14.02k stars 5.74k forks source link

Add mathematical functions to Jax frontend #8426

Open fnhirwa opened 1 year ago

fnhirwa commented 1 year ago

These functions can be found in jax.numpy namespace

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen. _

The main file paths where these functions are likely to be added are:

ivy/functional/frontends/jax/numpy/mathematical\_functions.py ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_jax\_numpy\_math.py ivy/functional/frontends/jax/numpy/name\_space\_functions.py ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_jax\_numpy\_namespace\_functions.py ivy/functional/frontends/jax/devicearray.py ivy\_tests/test\_ivy/helpers/function\_testing.py ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_jax\_devicearray.py

TakshPanchal commented 1 year ago

exp is already implemented, but it is still not ticked in this dashboard.

karalleyna commented 1 year ago

The following tests are not implemented:

fnhirwa commented 1 year ago

The following tests are not implemented:

  • [x] arcsin
  • [x] log1p

Hey would you add them😊

karalleyna commented 1 year ago

The following tests are not implemented:

  • [x] arcsin
  • [x] log1p

Hey would you add them😊

I already implemented them :)

vandit98 commented 1 year ago

roll #10889

lucasalavapena commented 1 year ago

Okay, apparently real is already implemented (See https://github.com/unifyai/ivy/commit/1f961d73158c261b2b04372c1121e1a51b1b15ad) even though there are no indication in this issue. Here is the relevant issue, based on GitHub it was referenced here so perhaps an entry issue or less likely there is an issue with the bot?

jdc98 commented 1 year ago
OkeyAmy commented 1 year ago
a0m0rajab commented 1 year ago

@AryanSharma21 in order to get your comments added to the list you need to follow this guides: https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues

What you are missing is this:

Comment on the ToDo list issue with a reference to this issue like so: - [ ] #Issue_number

AryanSharma21 commented 1 year ago

Hey @a0m0rajab thanks for the help

a0m0rajab commented 1 year ago

@AryanSharma21 you are welcome, I think you need to have an empty space as well after brackets.

spidy1996 commented 1 year ago

There are so many tasks which are completed and not marked as completed. Please rectify it, it already isn't less confusing for a newbie like me.

a0m0rajab commented 1 year ago

@spidy1996 which tasks are completed that you noticed?

OkeyAmy commented 1 year ago

"cos" function

spidy1996 commented 1 year ago

@spidy1996 which tasks are completed that you noticed?

@a0m0rajab Cos, cosh, exp, mod, round. There would be others as well, I'm sure of it.

a0m0rajab commented 1 year ago

@spidy1996 which tasks are completed that you noticed?

@a0m0rajab Cos, cosh, exp, mod, round. There would be others as well, I'm sure of it.

I think it's okay since it has been checked in the checklist: image

There is no need to connect with it's related issue (doing this would be better though but yeah) You can still find the related task with this: https://unify.ai/docs/ivy/overview/contributing/the_basics.html#who-to-ask

Mwangi-ke commented 1 year ago

21787

AbdullahSabry commented 1 year ago
ChibuezeOnejeme commented 1 year ago
ro4i7 commented 1 year ago
20481A05K0 commented 1 year ago

hey there may i know the problem clearly actually maximum all mathematical functions are implemented then what is the issue

20481A05K0 commented 1 year ago

Hello there!! does gradient is implemented in jax frontend or can i start working on it please respond asap