search

ivylabs / suitecrm-data-integration

6 stars 5 forks source link

Set Adhoc Service line Items to a Quantity of 1 by default #176

Closed harrisward closed 3 years ago

harrisward commented 3 years ago

Adhoc Service line item quantities are set to 0 in the source system. We should set this to 1 instead. It is also used as a multiplier to calculate the discount of the service line item

harrisward commented 3 years ago

@johnM2401 I've made the changes in the ETL for both the F_SALES and F_INVOICE_MANAGEMENT tables which are based off sales data in SuiteCRM. Can you test the branch below?

harrisward commented 3 years ago

Feature Branch: https://github.com/ivylabs/suitecrm-data-integration/tree/feature-176 Pull Request: https://github.com/ivylabs/suitecrm-data-integration/pull/177

johnM2401 commented 3 years ago

Hey @harrisward

Looks good to me, both Sales Reports seem to be reporting correct Service Line Quantity/Discount

Can be merged to master!