search

ivylabs / suitecrm-data-integration

6 stars 5 forks source link

F_INVOICE_MANAGEMENT - Table appears to no longer populate with the ./run script #178

Closed johnM2401 closed 3 years ago

johnM2401 commented 3 years ago

Describe the bug When running the ./run script, it appears that the F_INVOICE_MANAGEMENT table no longer populates.

The other F_XXXXX tables appear to populate fine, even F_SALES, which uses Invoice data.

Additionally, the F_INVOICE_MANAGEMENT table appears to populate when Demo Data is used.


After a little bit of investigation, if I reset the Master branch back to Jun 23, (commit: 7d04ba19c4246d89b2ef898c54c247b8eab3d821 ) Then the Table appears to populate correctly.

So, it appears it may be something in the latest two commits that have caused this issue.


**Solution File F_INVOICE_MANAGEMENT


To Reproduce Steps to reproduce the behavior:

  1. Create valid Invoice Data in the CRM
  2. Run ./run script
  3. Check D_INVOICES , F_SALES and F_INVOICE_MANAGEMENT, all of which should contain data Expected behavior A clear and concise description of what you expected to happen.


Screenshots

F_SALES: image

F_INVOICE_MANAGEMENT: image

D_INVOICES: image

harrisward commented 3 years ago

Hi @johnM2401 . Good catch. Small error in the ETL. I think we need to consider creating some unit testing to catch these silly issues! Our bad.

Can you test master please?

johnM2401 commented 3 years ago

Hey, @harrisward

Looks good, F_INVOICE_MANAGEMENT now populating!