search

ivylabs / suitecrm-data-integration

7 stars 5 forks source link

Replace 0 Dimension Keys with Text #6

Closed harrisward closed 4 years ago

harrisward commented 5 years ago

Dimension keys with a value of 0 have null text references. We need to replace this with "Not Set" so that filters in reports work correctly for facts that are not associated with a valid dimension key

samus-aran commented 4 years ago

This appears to be working, I see tables being generated with Not Sets Testing on branch 1.1

samus-aran commented 4 years ago

Same again. Appears to be working still for 1.1

harrisward commented 4 years ago

Tested and fixed