Resistance scripts - Githubissues

iw2d / kinoko

mushroom game server emulator for v95

16 stars 19 forks source link

Resistance scripts #23

Open stojostv opened 8 hours ago

stojostv commented 8 hours ago

Added all Resistance job advancement + training scripts
Added Schiller drop.
Added some Edelstein town quest / portal scripts.
Added a "isLeft" optional param to spawnMob, as Schiller's spawn would sometimes be facing right for 1 frame.
Added sm.removeNpc (also added to "froghiver" script)
Added sm.addSp (only tested with Resistance jobs)

Let me know if I forgot something.

iw2d commented 7 hours ago

Notes on ScriptManagerImpl::addSp

manually locking the user during script execution is not required because the user gets automatically locked (and unlocked while waiting for their input from dialogs)
ExtendSp::setSp method was being used, which sets the SP value, not adding to it
I think it's better to be specific about which job level the SP should be added to
SP from job advancements are handled by ScriptManagerImpl::setJob