search

iw4p / proxy-scraper

scrape proxies from more than 5 different sources and check which ones are still alive
MIT License
492 stars 126 forks source link

Cleaner Code with OOP #15

Closed itsamirhn closed 2 years ago

itsamirhn commented 2 years ago

I created class for multiple websites and used inheritance for removing duplicate codes in scraper script. Also I synced the scrapper and checker code style for feature developments.

I deleted all global variables too.

iw4p commented 2 years ago

None of Flake8 (PEP8) tests passed. Not a big deal, but if you don't wanna work on it anymore, keep me informed to merge the pull request.

itsamirhn commented 2 years ago

I fixed flake8 issues, sorry for previous mistake :D

itsamirhn commented 2 years ago

Done!

iw4p commented 2 years ago

Your PR merged successfully. Thank you Amir Mohammad :D