maint(map rotation): add compatibility layer for very old mods

diamante0018 commented 2 months ago

What does this PR do?

I was requested by Xerxes who is now allegedly running this patch on a fork, to add back some code that would allow his plugin to work. This has the advantage of fixing some really old map vote mods as well.

How does this PR change IW4x's behaviour?

Users can change the map rotation dynamically with sv_maprotationCurrent Dvar and have their changes persist even after one map rotation before the Dvar was cleared after just one rotation.

Anything else we should know?

This does not modify or break current setups of any kind and should be a welcomed change.

Did you check all the boxes?

[X] Focus on a single fix or feature; remove any unrelated formatting or code changes
[X] Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
[X] Follow our coding conventions
[X] Minimize the number of commits

diamante0018 commented 1 month ago

I forgot about the code comments, so I guess I'll stick to them since I have authored them. I have told xerxes that if he wanted the old map rotation system in IW4x then he can open a PR himself but I will no longer pursue this myself.

Rackover commented 1 month ago

🙈🙊🙉

iw4x / iw4x-client

maint(map rotation): add compatibility layer for very old mods #134