Discard non-existent dvar

[enclave]

What does this PR do?

This commit removes all references to it and uses aim_lockon_strength as the scale/strength factor when calculating the lock-on pitch turn rate. This aligns with the behavior in the Xbox 360 version of the game.

How does this PR change IW4x's behaviour?

I am unsure as I do not have a controller to test.

Anything else we should know?

The dvar aim_lockon_pitch_strength exists in T5 (I believe from recollection). Whether there should be seperate dvars for lock-on pitch and yaw strength is another question, and if so, the dvars should then be registered properly.

[diamante0018]

Good catch, yeah IW4x controller support was pasted from T5 and not IW4 Xbox so mistakes like this happened.

[Rackover]

Is there a reason why we would want to discard this variable?

It allows managing the pitch correction separately from the yaw correction. Sure, it might not exist in IW4 Xbox. But IW4x contains a lot of other stuff that does not exist on IW4 Xbox... ! I'm not sure how this is relevant.

Could you describe in details what problem this PR intends to solve? 🤔

[enclave]

This PR will bring parity to how the lock-on turn rates are calculated on the Xbox 360 version of the game using a single dvar (aim_lockon_strength) as the strength/scale factor.

While you're correct that this does not need to be followed just because it's done that way on the Xbox 360 version, if a separate dvar such as aim_lockon_pitch_strength is desired, then the dvar should be registered properly. As the dvar does not actually exist since it's not registered by the game, this line of code will consequently register an empty string dvar, due to the implementation of Dvar::Var. Therefore, in the provided screenshot you are able to see how this dvar is missing an assigned value and more.

[Rackover]

I understand better now! 🙂 Thansk for the explanations In that case I would rather have this PR add a registration for this Dvar, so that it is valid to the game and displayed with the correct tyype / boundaries / restriction, instead of removing the Dvar altogether, if that's okay

[Rackover]

Tested and works