search

iw4x / iw4x-client

GNU General Public License v3.0
113 stars 35 forks source link

fix: removed hook that can crash when loading zone #91

Closed WantedDV closed 5 months ago

WantedDV commented 6 months ago

What does this PR do?

Removing this hook fixes the crash when loading into Chinatown. Closes https://github.com/iw4x/iw4x-client/issues/72

How does this PR change IW4x's behaviour?

I did not pick up on any unwanted changes.

Anything else we should know?

It might be worth looking into the Chinatown to figure out what sets it apart from the rest. One thing I noted was that the loading screen for this map seems to struggle with showing the correct map name: it will start off with "Chinatown" briefly, then show "Unknown", and finally, "Chinatown" again. The console reports Overriding asset 'MPUI_CARENTAN' of type localize. This is the only map I noticed that would do this.

WantedDV commented 5 months ago

It makes sense why the loading screen does Chinatown->Unknown->Chinatown: Unknown happens at the same moment that Overriding asset 'MPUI_CARENTAN' of type localize is printed and is resolved quickly after, so my guess is that the asset is unavailable briefly during this process. It might not be anything to worry about, but this map is the only map I noticed that tries to override this asset so I figured I'd mention that.

and thank you :)