search

iwa / Q-Bot

Custom Discord Bot made for Qumu's Discord Server
0 stars 0 forks source link

response to assigning new colour broken #35

Closed Hyperfresh closed 4 years ago

Hyperfresh commented 4 years ago

image

i also didn't notice it was happening to others too image wonder what could be causing it...?

Hyperfresh commented 4 years ago

for reference: https://discordapp.com/channels/225359327525994497/611349541685559316/710626243103686737

Hyperfresh commented 4 years ago

i think it broke when i replaced `` with "" in color.ts as per 22d3eeb. problem with changing that is the "type ?color off" won't work because of ``, so...

Hyperfresh commented 4 years ago

Found the solution! Probably. Doing \` might fix the issue. I'll send it over in a PR.

Hyperfresh commented 4 years ago

so commit cf65c2d / PR #37 should fix the issue. have a look

iwa commented 4 years ago

yeah, you have to use `` instead of "" single and double quotes are used to register literal strings, and can only adds vars into them by using concatenation, which is a really bad thing for the memory

if i'm not wrong, ` comes from JQuery, and has been added to Node do the same thing asString.Format()in C# and.format()` in Python