search

iwa / Q-Bot

Custom Discord Bot made for Qumu's Discord Server
0 stars 0 forks source link

Update music module to use a song-array as the queue #85

Closed brandonbothell closed 4 years ago

brandonbothell commented 4 years ago

I would have used a map and made it guild-specific, but that didn't meet the specifications in #73. So, I thought about mapping the queue via the song IDs, but I noticed that the remove command depends on the songs being mapped by indexes.

This left me with this, which is still much cleaner than the previous implementation.

iwa commented 4 years ago

thanks a lot for your PR!

yeah I planned to make that much more cleaner than it was (haven't worked on the music module for a few months ^-^; ), so thanks for that keep using an array works, but I thought about changing it for a map, which seems to be faster & safer 🤔

iwa commented 4 years ago

anyway, gonna keep using an array for now, thanks for your help!