search

iwanders / OBD9141

A class to read an ISO 9141-2 port found in OBD-II ports.
MIT License
227 stars 70 forks source link

KWP 5baud init #19

Closed arezaie14 closed 4 years ago

arezaie14 commented 4 years ago

Add KWP 5baud init ability

iwanders commented 4 years ago

Hi, thanks for taking the time to file a pull request. However, I did close all 9 PR's you made today.

Spreading out each line over one different PR makes it impossible to review and discuss. Spreading it out over commits is fine, but if multiple changes span one functional change they should be in the same PR. I tried looking for your fork to look at a development branch there to get an overview of the changes, but I didn't see a fork of it in your namespace. I'm not going to stitch together a branch to get an understanding of what you were trying to do. If you want me to take a look and consider it, please file a PR that includes all changes.

Additionally, please consider whether breaking the current API to add your feature is reasonable. Especially since this seems a very small use-case.