search

iwanders / OBD9141

A class to read an ISO 9141-2 port found in car diagnostic OBD-II ports.
MIT License
237 stars 72 forks source link

Kwp simulation #53

Closed ankayca closed 9 months ago

ankayca commented 9 months ago

KWP message frame added to simulation side. MC3360 and arduino uno used for tests. This my first pull request so I anything wrong my bad.

iwanders commented 9 months ago

One comment about adding the assignment of use_kwp_ to false in the constructor wasn't addressed, please add that, other than that it looks good.

iwanders commented 9 months ago

Looks good now, I'm going to merge this.

Thanks for your contribution @ankayca !