search

iwarapter / sonar-puppet

SonarQube plugin for Puppet code.
Other
26 stars 10 forks source link

#245 Added support for grouping related indent issues. #248

Closed iwarapter closed 8 years ago

iwarapter commented 8 years ago

@racodond does this meet the use case you had for #245?

racodond commented 8 years ago

@iwarapter Yes, it is exactly what I would expect. Just check the number of "following lines" that is wrong from my point of view.

iwarapter commented 8 years ago

Its a case of wording I wrote it to mean this line plus the following x lines. Do you think it's not very clear?

racodond commented 8 years ago

It's what I guessed but it is not clear at all from my point of view. Just saying "The following X lines should start on column N." (X including the current line) is more understandable from my point of view.

iwarapter commented 8 years ago

No worries, ill add that to it when i get home.

iwarapter commented 8 years ago

@racodond updated.

racodond commented 8 years ago

Cool! Thanks a lot!