iwarapter / terraform-provider-jwks

Terraform Provider to help work with JWKS
MIT License
7 stars 9 forks source link

feat: add kid generation according to kubernetes #97

Open jobcespedes opened 4 months ago

jobcespedes commented 4 months ago

I suggest to include this feat from @jlmwork. I was going to program it but found his work first.

Description:

Used to populate the kid field of the JWK with the a key ID non-reversibly from the public key (only with public keys in PEM format).`

See inline comment

Notes:

  1. Work done by https://github.com/jlmwork/terraform-provider-jwks/commit/f2374a74d7b70ad26ac360b7b87b4a6286e072e3
  2. I rebase the code since his work was done a while ago
  3. I updated the docs
iwarapter commented 4 months ago

Hey thanks for this I'll take a look when I'm back from holiday

yagnasrinath commented 1 month ago

One of the other possible ways to generate kid according to https://www.rfc-editor.org/rfc/rfc7638.html#:~:text=by%20using%20the%20base64url%2Dencoded%20JWK%20Thumbprint%20value%20as%20a%0A%20%20%20%22kid%22%20(key%20ID)%20value is via thumbprint. As such there is no standard way.