iwd-nl / snelstart-php

PHP 7.2+ Library for the Snelstart API https://b2bapi-developer.snelstart.nl/
8 stars 23 forks source link

Add Kasboeking and Dagboek functionality #18

Open ikulis opened 3 years ago

ikulis commented 3 years ago

Dagboek [findAll] Kasboeking [find/add/update/delete]

Made mode specific class SnelstartPHP\Model\V2\Koopboeking which is extended by Verkoopboeking and Inkoopboeking, so I can extend the base SnelstartPHP\Model\V2\Boeking.

manuelderuiter commented 3 years ago

Thanks for your contribution! It looks great so far. Haven't had the opportunity to test it yet.

arwinvdv commented 2 years ago

@ikulis to add a Kasboeking, the inkoopboekingBoekingsRegels and verkoopboekingBoekingsRegels params has to have an boekingId. I fixed it in 2119addf3fd262589b03ae8a30b97d944fbc1feb

edit: typo

ikulis commented 2 years ago

@arwinvdv Indeed overlooked it, I was testing with the grootboekBoekingsRegels. Thank you for testing that one. Are you able to attach to the pr or should I do it?

arwinvdv commented 2 years ago

I'm not that experienced with pull requests so it would be nice if you can do that.