search

iwonbigbro / gsync

RSync for Google Drive - GSync
Other
238 stars 50 forks source link

MemoryError() with the checksum option with large files #32

Closed inderweltsein closed 10 years ago

inderweltsein commented 10 years ago

MemoryError(): File "/usr/local/lib/python2.6/dist-packages/libgsync/sync/file/local/init.py", line 102, in _md5Checksum m.update(f.read())

That obviously implies 'md5Checksum' = None and that the file is transferred even if it has not changed

iwonbigbro commented 10 years ago

Ah, that m.update() line is awful. It will result in the entire file being read into memory before being added to the hash. I'll fix this now. Are you able to install from source?

On 21 October 2013 12:47, inderweltsein notifications@github.com wrote:

MemoryError(): File "/usr/local/lib/python2.6/dist-packages/libgsync/sync/file/local/init.py", line 102, in _md5Checksum m.update(f.read())

That obviously implies 'md5Checksum' = None and that the file is transferred even if it has not changed

— Reply to this email directly or view it on GitHubhttps://github.com/iwonbigbro/gsync/issues/32 .

iwonbigbro commented 10 years ago

I can have a new release on pypi for this bug tonight.

iwonbigbro commented 10 years ago

I have just released 0.1.13 on pypi.