search

iwyg / jitimage

Just In Time image manipulation (GD, Imagick, imagemagick) with integration for laravel 4
MIT License
95 stars 8 forks source link

Actually define cache.prefix without underscores #19

Closed cviebrock closed 10 years ago

cviebrock commented 10 years ago

The code here adds an underscore to the cached image URL:

https://github.com/iwyg/jitimage/blob/master/src/Thapp/JitImage/Cache/ImageCache.php#L121-L130

Can I suggest that the sprintf() string be changed from '%s.%s_%s.%s to '%s.%s%s.%s so that, if I don't want any underscore characters in my cached images, I won't get them?

This may seem like a minor point ... but Facebook, I believe, has trouble with images that contain underscores when using them for publishing to feeds (see http://stackoverflow.com/a/5572622/1327340 ).

cviebrock commented 10 years ago

Thank you!

iwyg commented 10 years ago

Now, if you need underscores, you have to set this on the cacheprefix ;)