search

iwyg / jitimage

Just In Time image manipulation (GD, Imagick, imagemagick) with integration for laravel 4
MIT License
95 stars 8 forks source link

Unable to publish package #28

Closed abhimanyu003 closed 10 years ago

abhimanyu003 commented 10 years ago

With the update of laravel v4.1.24 not able to publish package. Error is

Missing argument 2 for Illuminate\Container\Container::Illuminate\Container\{closure}()

I'm not sure but seems error is with registering the package with the new update of laravel

iwyg commented 10 years ago

hm, would be odd if there's breaking change in the public api after a minor update. I'll have a look asap. Does this only happen when firing up artisan?

abhimanyu003 commented 10 years ago

Yes this only happen when firing artisan command(s).

To test this I run composer update by removing post-update-cmd from composer.json file. Then manually trigger php artisan clear-compiled and same thing happen.

iwyg commented 10 years ago

No, it also happens when firing up laravel in general. I've spotted the container binding that's causing this issue. However I think it's a bug on laravel's side.

iwyg commented 10 years ago

for reference: filed a bug here

iwyg commented 10 years ago

temporary fix https://github.com/iwyg/jitimage/commit/709d94413e75730388605d0104c98a50a9af9757

abhimanyu003 commented 10 years ago

Thanks a lot for fix, let see what Taylor reply on this