Closed felixhaeberle closed 6 months ago
@felixhaeberle is attempting to deploy a commit to the Ixartz's projects Team on Vercel.
A member of the Team first needs to authorize it.
@felixhaeberle Thank you for your PR. Unfortunately, i18n-ally has still more features: https://github.com/lokalise/i18n-ally/pull/1048#issuecomment-2110462158
Not a huge fan about the inlang
folder, the configuration of the extension should be done directly in VSCode and not in a new folder. It seems the extension was built for inlang
project and not for next-intl
.
Another thing project.inlang/project_id
file, how this value is generated?
@ixartz
i18n-ally has still more features
What features do you miss in Sherlock that i18n-ally provides? We're keen to build them for you, and are fast to do so.
Not a huge fan about the inlang folder, the configuration of the extension should be done directly in VSCode
What is the downside of having this folder?
"done directly in VSCode" -> the .inlang
folder is exactly that, configuration as code inside your project in VSCode
But its not only that, you get the possibility to join the inlang ecosystem with lots of i18n apps all working seamlessly together, like Fink – a git based i18n editor. Or have you already seen Ninja – GitHub action which saves you from broken / missing translations.
It seems the extension was built for inlang project and not for next-intl.
Sherlock is built completely unopinionated, supporting a wide margin of libraries.
Links
See: https://inlang.com/m/r7kp499g/app-inlang-ideExtension/supported-i18n-libraries
And even the nex-intl
docs recommend Sherlock: https://next-intl-docs.vercel.app/docs/workflows/vscode-integration#sherlock
Another thing project.inlang/project_id file, how this value is generated?
This value is based on the first git commit hash & needed for internal processing of a project inside a repository, as all inlang ecosystem tools build on top of git.
I also join the opinion shared on this discussion: https://github.com/lokalise/i18n-ally/pull/1048, several people has tried the extension
Having the .inlang
folder makes the Sherlock opinionated. You are somehow "required" to join the inlang ecosystem.
For all the extensions suggested by the project, all the configurations happens in .vscode
and there is not need to have extra files or folders outside of .vscode
folder.
The author of next-intl
himself still have a preference for i18n-ally: https://github.com/lokalise/i18n-ally/pull/1048#issuecomment-2110462158
I also join the opinion shared on this discussion: https://github.com/lokalise/i18n-ally/pull/1048, several people has tried the extension
You mean this one? https://github.com/lokalise/i18n-ally/pull/1048#issuecomment-2093253531
Having the .inlang folder makes the Sherlock opinionated. You are somehow "required" to join the inlang ecosystem.
There is really no downside to it. It completely free & open source, has good support and a active discord with 24/7 support right at your fingertips. If you think about it, i18n-ally also does settings in the setting.json of VS Code, with the difference that for Sherlock you have a different settings.json, making it possible to use all the other tools in the inlang ecosystem.
The author of next-intl himself still have a preference for i18n-ally: https://github.com/lokalise/i18n-ally/pull/1048#issuecomment-2110462158
I don't know. The linked comment was regarding the plugin support of next-intl
in i18n-ally
vs the custom one – not compared to Sherlock. We support the latest next-intl
syntax and in terms of parsing source code, you get better results.
Apart from that, your users get a maintained VS Code extension, machine translations via the inlang CLI, and CI/CD i18n checking with Ninja & lots more. https://inlang.com/c/apps
It's a bit strange to trust an unmaintained solution that sooner or later will introduce security issues (especially crucial for a SAAS boilerplate which recommends this) based on that fact instead of a new & thriving extension where they can wish for everything they want; issues open: https://github.com/opral/inlang-sherlock
To improve Sherlock for next time: What features do you miss in Sherlock that i18n-ally provides?
we are going to update i18n-ally very soon, apologies for the delay
@kibertoad Thank you so much! Extremely existed about i18n-ally new updates!
This PR aims to replace the unmaintained i18n-ally extension for Sherlock.
https://marketplace.visualstudio.com/items?itemName=inlang.vs-code-extension
Sherlock is a new & lightweight library for VS Code which offers the same functionalities & is well maintained.
Feel free to request changes in order to get this merged.