ixblue / ixblue_ins_stdbin_driver

ROS driver for iXblue inertial sensors supporting StdBin protocol
MIT License
9 stars 13 forks source link

Wrap longitude in [-180,180] to follow sensor_msgs/NavSatFix.msg #15

Closed romainreignier closed 3 years ago

romainreignier commented 3 years ago

Fix #12

Another implementation to avoid the angles dependency and avoid the radians conversion could be:

if(res->longitude > 180.0)
{
    res->longitude  - 360.0;
}

@adrienbarral and @1r0b1n0 which one do you prefer?

romainreignier commented 3 years ago

@ros-pull-request-builder retest this please

romainreignier commented 3 years ago

I went for the simpler solution. @adrienbarral and @1r0b1n0 Ok to merge ?

romainreignier commented 3 years ago

The melodic stretch build error is due to ros infra. See https://github.com/ros-infrastructure/rosdep/issues/794