search

ixc / ixc-django-docker

Scripts and config files that make it easier to run Django projects consistently with and without Docker.
5 stars 1 forks source link

Python 3 compatibility #14

Closed markfinger closed 6 years ago

markfinger commented 6 years ago

The glaring issues are in https://github.com/ixc/ixc-django-docker/blob/master/ixc_django_docker/bin/waitlock.py, which has a lot of code handling stdout/stderr that will need to be updated to properly handles bytes+str.

I took a 10 minute stab at it, but I ran into problems in the python-redis-lock package (locks could never be acquired). I hacked out a reimplementation of the lock acquisition with the redis package's builtin lock: https://github.com/andymccurdy/redis-py/blob/master/redis/lock.py, which seemed to fix the acquire and uncovered some more bytes/str errors, so I bailed and focused on other things.

markfinger commented 6 years ago

Note that these issues are preventing us from upgrading to Django 2+ and Wagtail 2+.

Aramgutang commented 6 years ago

I think we've fixed all the issues pertaining to this that have come up so far.

markfinger commented 6 years ago

Cool. We should probably give it a whirl with agsa and see how it goes

Aramgutang commented 6 years ago

It's working fine with Australian Museum. Are we also moving AGSA to py3?

markfinger commented 6 years ago

There's no pressing need, but it would be a good idea

markfinger commented 6 years ago

Everything looks good

Thanks for the fixes, Aram :)