search

ixc / ixc-django-docker

Scripts and config files that make it easier to run Django projects consistently with and without Docker.
5 stars 1 forks source link

Make S3 private storage ignore problematic `AWS_S3_CUSTOM_DOMAIN` setting #24

Open jmurty opened 4 years ago

jmurty commented 4 years ago

Ensure the private storage class always ignores the optional Boto setting AWS_S3_CUSTOM_DOMAIN.

Without this hack, when that setting is applied it affects all storage classes and causes them to generate URLs to S3 objects with the given domain and without any request signing, producing invalid URLs for private objects.

See related commit for RFDS in amongst the long issue #193: https://github.com/ixc/rfds/commit/a14b0748