search

ixc / ixc-django-docker

Scripts and config files that make it easier to run Django projects consistently with and without Docker.
5 stars 1 forks source link

newrelic.sh doesn't run with Python3.7 #27

Open aweakley opened 4 years ago

aweakley commented 4 years ago

I had to upgrade to a newer NewRelic. It was this issue: https://discuss.newrelic.com/t/async-and-await-will-be-reserved-keywords-in-python-3-7/53297

I ended up with newrelic==5.14.1.144 but it appears to work with anything >=2.100.0.84

jmurty commented 4 years ago

From Slack:

I think that I should put the minimum version in https://github.com/ixc/ixc-django-docker/blob/master/setup.py Should I just go with the earliest-working version, or a more recent one?

jmurty commented 4 years ago

@aweakley I think it would be reasonable to set a minimum version in ixc-django-docker's setup.py to force installation of more up-to-date versions, though it is arguably the project's responsibility to pin (and then update) its version of the new relic lib to be appropriate for the Python version the project is using.

jmurty commented 4 years ago

Also, since any projects that are using very outdated versions of the newrelic library aren't likely to be using an up-to-date version of ixc-django-docker anyway, enforcing a minimum version here isn't likely to avoid the problem in any existing projects.