search

ixc / letsencrypt-docker

Automatically create or renew certificates on startup and daily thereafter.
26 stars 15 forks source link

Make Let's Encrypt certificate updates more robust across docker versions #4

Open jmurty opened 7 years ago

jmurty commented 7 years ago

We have seen failures in certbot.sh updating certificates caused by a mismatch between the agent and docker versions, more details here: https://github.com/drone/drone/issues/2048

Look into this in more detail and come up with a way to ensure the agent will run in a way that is compatible with the rest of the Docker environment, which might mean hardcoding something like a DOCKER_API_VERSION=1.23 envvar before invoking certbot.sh or maybe detected the right version number to apply in this way.

mrmachine commented 7 years ago

@jmurty this should be taken care of automatically by this: https://github.com/ixc/letsencrypt-docker/blob/c6e9f8003056aef7a4a77c2c6c11643e04d87d58/bin/entrypoint.sh#L13-L19

Maybe it no longer works, if a new Docker client changed the format of docker version output?