search

ixc / python-edtf

MIT License
52 stars 19 forks source link

Fix tests on CI #67

Open rettinghaus opened 3 months ago

rettinghaus commented 3 months ago

It seems like test only run properly for owners of the repo. Tests are green on my fork, but they fail here for PRs.

ColeDCrawford commented 2 months ago

For a while there was an issue on my fork when the workflow attempted to publish benchmark results to a non-existent Github Pages site, but I fixed that. I am also experiencing failing tests at the "Pytest comment" step during PRs from forks. Reruns of the CI workflow use "the privileges of the actor who initially triggered the workflow, not the privileges of the actor who initiated the re-run" (docs) so that's not a manual option either.

We could try changing the workflow to use the fork's context (where contributors have permission) by running it on pull_request_target? That seems less than ideal. Otherwise I think we would need to move the Pytest coverage comment step. @aweakley any thoughts?