search

ixc / wagtail-instance-selector

A widget for Wagtail's admin that allows you to create and select related items
MIT License
54 stars 17 forks source link

Support for Wagtail v5.0 #34

Closed nickmoreton closed 1 year ago

nickmoreton commented 1 year ago

This PR updates the package for Wagtail v5.0 compatibility.

It also includes the following PR's and they could be closed if this is accepted:

Some of the tests are no longer relevant. They have been updated but the original assertions left in place as comments and may be useful for the maintainer to review and update.

The UI is no longer rendered as the screen shots show and further work would be required to fix that but the select boxes work as expected.

katdom13 commented 1 year ago

Hi @nickmoreton , I created a PR on your branch to apply the suggested changes from my comments: https://github.com/nickmoreton/wagtail-instance-selector/pull/4

I reckon I'll just merge my changes in this branch to avoid further confusion due to multiple PRs on the parent project involving the 5.0 upgrade.

Thanks!

katdom13 commented 1 year ago

HI @nickmoreton , This PR can be closed in favor of: https://github.com/ixc/wagtail-instance-selector/pull/35

nickmoreton commented 1 year ago

Closing as this PR is no longer required.